Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron doesn't always automatically reset dailies, need to manually pull to refresh #770

Closed
saraolson opened this issue Nov 14, 2018 · 11 comments

Comments

@saraolson
Copy link
Collaborator

"Once cron occurs, the only way to get dailies to reset is to manually refresh (drag them down to get the spinning wheel)" It's happened for awhile in the past, more than once

@kevincoleman
Copy link

While this behavior can be kind of handy for manually handling a cron, it does seem like the wrong way to put power in users’s hands. It’s a bit hidden, and makes users work for a normal cron even after they know where to go.

Alternatives?

  • Just auto cron at the set time
  • move option to trigger cron into a more tucked away place and label it more clearly
  • make a button explicitly for this feature instead of a pull-down spinner to proc it
  • other?

I think I like the first two in combo...

@phillipthelen
Copy link
Member

That the user has to use pull to refresh to get the dailies to display correctly is a bug that happens in rare cases. Not something that is intentional or happens often. The correct flow is:

  1. User receives modal to check off remaining tasks (if there are any. if not, it crons automatically)
  2. user checks tasks off and taps button on the modal to start their day
  3. App completes the tasks and then runs cron
  4. App updates the dailies to reflect the new day.

The bug described here happens when something between 3. and 4. goes wrong and 4 doesn't happen automatically and instead the user has to refresh the tasks manually.

@kevincoleman
Copy link

kevincoleman commented Jul 23, 2019

Ah ok. That flow sounds about right—however, in my experience that “something” happens most if not all days.

Would it be helpful to extract and submit logs or something?

@kevincoleman
Copy link

Revisiting this—

Both of my party members have to pull to refresh the list every new day they use the app. I myself have to do it every day as well. Unless there’s something strange about my party in particular, this sounds like it’s much more common than “rare”.

Do we have statistics on how often people manually pull down the list of dailies to cron? That might be a good place to start. Validate, reproduce, investigate, fix?

@phillipthelen
Copy link
Member

It‘s not really possible to log this, since cron did already run at the point where the user is refreshing manually. The part that hasn‘t happened yet is the dailies displaying this. So there is no real way to reliably log this, since it‘s hard/impossible to distinguish from a regular refreshing. If it were that easy, we would have already tried it.

When the dialog to check off your remaining dailies appears, do you check off many tasks there? Also, how long do you wait after the dialog until you refresh manually? Just to be sure that the issue is not just that the request for refreshing the tasks already started st the point where you refresh manually

@kevincoleman
Copy link

Ah, makes sense on logging.

Sometimes I check off things on the modal for yesterday’s dailies, and sometimes I don’t check off anything. It doesn’t appear to make a difference.

I haven’t timed it, but I usually wait a few seconds. I think there have been times when I go do something else in-app first, so that would mean quite some time has passed before the manual reload. I’ll try waiting a couple minutes tomorrow to verify this behavior.

A party member just confirmed the need to manually refresh every time after trying it again today, and I saw it again too.

@kevincoleman
Copy link

Confirmed it’s not just a delay. After dismissing the modal for yesterday’s items the dailies list seems to be showing yesterday’s state until a manual load is initiated.

@kevincoleman
Copy link

I’m curious if anyone else can reproduce these symptoms.

@xanenv
Copy link

xanenv commented Aug 7, 2019

@kevincoleman Yes, this specific issue happens to me daily, on iPhone XR. Everything you describe is spot-on with my experience with the app.

@xanenv
Copy link

xanenv commented Aug 11, 2019

Another issue that happens when it attempts to have you check off items that you may have missed last night, is it shows failed that weren’t from yesterday. For example I have weekday and different weekend dailies, and this morning it showed dailies from the week, and if I click on them it marks negative points. So I just have to ignore them and start my day. When I do this, it doesn’t take off any points or health.

@kevincoleman
Copy link

Interesting. I’ve noticed some anomalies in the modal’s behavior too. You should spec that out in detail and open a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants