New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Challenge tag is not always created when a player joins a challenge #10689
Comments
donotgogentle馃尲馃尫馃尰 says: "I don't use on multiple devices though sometimes I keep multiple browsers with instances of Habitica open. I don't use any third-party related tools. Ok, I'll try syncing first next time." |
Another confirmed report of this from @thebat137 (dea8a9e8-c084-438a-9a14-7fe96a73fd0a): |
Another report, although second-hand (the affected user has not reported it directly): @thebat137 says: |
More reports: @ravenlune (9272ab2c-4b66-4b74-aebd-799725885d1c): "I hadn't noticed until today, but I joined a few challenges earlier this month and never got a challenge tag associated with them (unless I deleted them sometime but I don't remember doing so). the ones in particular are October haiku, October senryu, 馃挱Constructive Self-Talk 鈥ctober Edition. Having the tags isn't a very big deal to me since I don't use them often but it seemed like it should be mentioned." |
Another confirmed report of this from @MaybeSteveRogers (767e5d92-0e13-4e30-acb1-d8bba62824fc) (Also I've deleted a couple of comments here that weren't directly about this issue and that were logged in #11420 ) |
With PR #12335 the Habitica codebase has been updated to support MongoDB 4.2 and transactions making it possible to fix this issue. Transactions allow operations on multiple documents to be executed ensuring that either all of them are executed correctly or none, making it possible to fix this issue. An example on using transactions can be found at https://mongoosejs.com/docs/transactions.html while more info at https://docs.mongodb.com/manual/core/transactions/. If you want to work on this issue and have any question please leave a comment! |
I'm open to take this |
In the Report a Bug guild, donotgogentle馃尲馃尫馃尰 (65be576c-c412-41c7-a31f-94994c8c4fc6) says:
When I join Challenges, sometimes the associated tag does not show up, though the tasks appear. Example of one I just joined: https://habitica.com/challenges/2350bb37-29f8-42dd-9a43-c3cc9e9d1939
I've confirmed that they are in that challenge and don't have the tag. They joined it on Sep 11, 11:45:04 pm UTC. There's no errors recorded in Loggly around that time, although there are quite a few "Your session is outdated" and "Notification not found" errors in the surrounding days, implying that the account is often in a state where failures might be occurring from multiple simultaneous actions or from the account being updated in two or more platforms / tools at the same time.
I don't recall seeing other reports of this so I'm marking it minor priority and needs investigation for now.
I imagine this problem would stop happening once we're using database transactions.
With PR #12335 the Habitica codebase has been updated to support MongoDB 4.2 and transactions making it possible to fix this issue.
Transactions allow operations on multiple documents to be executed ensuring that either all of them are executed correctly or none, making it possible to fix this issue.
An example on using transactions can be found at https://mongoosejs.com/docs/transactions.html while more info at https://docs.mongodb.com/manual/core/transactions/. If you want to work on this issue and have any question please leave a comment!
The text was updated successfully, but these errors were encountered: