Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Justin intro modal to separate it from avatar edit #10803

Open
SabreCat opened this issue Nov 2, 2018 · 5 comments
Open

Refactor Justin intro modal to separate it from avatar edit #10803

SabreCat opened this issue Nov 2, 2018 · 5 comments

Comments

@SabreCat
Copy link
Member

SabreCat commented Nov 2, 2018

Description

creatorIntro.vue is used both for initial avatar setup on account creation, and for editing a user's avatar via the user menu. This makes it difficult to consistently position both modals, because ideal positioning for the Justin sequence pushes the much larger avatar edit modal partially offscreen.

What we should do is pull the shared avatar-related pieces out to a component that's then plugged into two separate modals, Justin and post-setup avatar editing. Then, reposition the Justin sequence so it's centered better onscreen.

@adamfitzgibbon
Copy link
Contributor

I'll start work on this one.

@Alys
Copy link
Contributor

Alys commented Oct 14, 2019

@adamfitzgibbon thanks! I've marked it as in progress for you.

@adamfitzgibbon
Copy link
Contributor

As an update, I'm still planning on completing this issue, but as I'm new to Vue I'm going to take some low-hanging fruit to get a little more experience before finishing it.

@adamfitzgibbon
Copy link
Contributor

I've gotten a little busier so will try to get around to doing this, but if anyone else is looking for something to try, feel free to let me know and grab it from me.

@Alys
Copy link
Contributor

Alys commented Dec 3, 2019

@adamfitzgibbon Thanks for letting us know! I've put this back to help wanted but post here if you'd like to take it up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants