Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Firefox Chat Extension" to the Settings > API page #11042

Closed
Alys opened this issue Mar 4, 2019 · 6 comments · Fixed by #11375
Closed

Add "Firefox Chat Extension" to the Settings > API page #11042

Alys opened this issue Mar 4, 2019 · 6 comments · Fixed by #11375

Comments

@Alys
Copy link
Contributor

Alys commented Mar 4, 2019

The User Icon > Settings > API page contains a link to the Chrome Chat Extension. There should also be a link to the Firefox Chat Extension, which is at https://addons.mozilla.org/en-US/firefox/addon/habitica-chat-client-v2/

Both extensions do the same thing, the only difference being the browser they run on. Because of this, I think it would be most helpful if the same bullet-point entry was used for both extensions - that should make it obvious that you're not missing out on anything if you install only one of them. The bullet point line could read "Chrome Chat Extension and Firefox Chat Extension" and the paragraph under it could be changed to this:

"The Chat Extension for Habitica adds an intuitive chat box to all of habitica.com. It allows users to chat in the Tavern, their party, and any guilds they are in."

I'll leave this issue open as suggestion-discussion for a few days and then if there's no objections or changes to this approach, I'll change it help wanted. I'll mark it as good first issue since it will be ideal for a new contributor. EDIT: This is on hold while some changes are being made to the extension.

@Markkop
Copy link
Contributor

Markkop commented Aug 21, 2019

Hey! This is a great first issue. Can I take it? I'm still setting up the development environment, but I'm pumped to contribute on Habitica and learn/practice VueJS

@Alys
Copy link
Contributor Author

Alys commented Aug 26, 2019

@Markkop Thanks, please go ahead! Comment here if you have questions.

@bmasetto
Copy link

bmasetto commented Oct 1, 2019

@Markkop, do you still working on this issue? If not and if @Alys agrees, I could go ahead with this implementation.

@Markkop
Copy link
Contributor

Markkop commented Oct 1, 2019

@Markkop, do you still working on this issue? If not and if @Alys agrees, I could go ahead with this implementation.

I've finished this issue with #11375, but it can't be resolved before the extension being avaliable again in Firefox's marketplace.
HabitRPG/habitica-chat-extension#49

@bmasetto
Copy link

bmasetto commented Oct 1, 2019

Ok, @Markkop. What do you think about adding an “on hold” label to this issue in this case, @Alys?

@Alys
Copy link
Contributor Author

Alys commented Oct 1, 2019

@bmasetto "on hold" is usually used if an issue isn't suitable for someone to start working on it, but for this one there's already a full fix, so it's sort of borderline between the two situations. :) I'll leave it marked as "in progress".

As a general guideline, if you see an "in progress" issue that hasn't had any action for several weeks, it's okay to ask if the claimant is still working on it, but it's best to check first if there's already a pull request (which will be linked from the issue). Once there's a PR any conversation about it usually happens in the PR so you can follow the progress there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants