New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update achievements to work with notification object #11257
Comments
Hello @phillipthelen! |
@Xaz16 I'll remove the label as this is being handled by @phillipthelen |
@paglias thank you :) |
@SabreCat Should this one get a Help Wanted tag again? |
SabreCat
added
Hacktoberfest
help wanted
and removed
status: issue: in progress
status: needs reply
labels
Oct 14, 2021
oh gosh, absolutely. Not touched since 2019! |
I'll take this one, too, since I'm also handling #11541 and they're related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The way achievements are displayed on web is often done by comparing the fields directly. Instead the server should update the
notifictations
property on the user to add information about the gained notification. Same way it is already done for the Ultimate Gear achievements or Back to basics. This is essential for the achievements to work properly across the mobile apps and the website.List of achievements that need to be updated:
I marked this as Help Wanted in case a contributor wants to work on one or multiple of these before I have time.
The text was updated successfully, but these errors were encountered: