Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update achievements to work with notification object #11257

Open
phillipthelen opened this issue Jul 8, 2019 · 6 comments
Open

Update achievements to work with notification object #11257

phillipthelen opened this issue Jul 8, 2019 · 6 comments

Comments

@phillipthelen
Copy link
Member

The way achievements are displayed on web is often done by comparing the fields directly. Instead the server should update the notifictations property on the user to add information about the gained notification. Same way it is already done for the Ultimate Gear achievements or Back to basics. This is essential for the achievements to work properly across the mobile apps and the website.

List of achievements that need to be updated:

I marked this as Help Wanted in case a contributor wants to work on one or multiple of these before I have time.

@Xaz16
Copy link
Contributor

Xaz16 commented Sep 14, 2019

Hello @phillipthelen!
Is it still Help wanted issue? As I can see we already have PR for that

@paglias
Copy link
Contributor

paglias commented Sep 14, 2019

@Xaz16 I'll remove the label as this is being handled by @phillipthelen

@Xaz16
Copy link
Contributor

Xaz16 commented Sep 14, 2019

@paglias thank you :)

@beffymaroo
Copy link

@SabreCat Should this one get a Help Wanted tag again?

@SabreCat
Copy link
Member

oh gosh, absolutely. Not touched since 2019!

@CuriousMagpie
Copy link
Member

I'll take this one, too, since I'm also handling #11541 and they're related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants