Group tasks with ‘need approval’ kill my party

[sarahjean]

I have set up a group, it seems like when I create a group task and set to ‘need approval’, and one of the members tries to click on it (both iOS) they immediately lose all their health and get the death screen. Also appear to be level 0. Then if they navigate around they get a message about leveling to their previous level and health reset. I have tried to reproduce the issue on my account but as the group manager I think it does not affect me.

It seems to happen on all three boards, habits, dailies, to do's. Tasks they made for themselves work fine.

Please let me know if more info is needed.

[thewilloftheshadow]

If you go to the Report a Bug guild and ask there, the staff will be able to help you troubleshoot and work through the issue better than they can here on GitHub, the issues here are more for the Blacksmiths (Coders) for Habitica to find problems from staff/mods that need to be fixed ;)

[sarahjean]

Sure, thanks. Will check it out.

[paglias]

I'm marking this as needs investigation in case it's resolved in RaB and pinging @SabreCat in case it's related to the recent work on group plans

[Alys]

Just to let you know, I've asked some troubleshooting information in RaB.

[sarahjean]

@Alys yes, thanks.
The damage alert occurs with any task created in the group that has 'needs approval' checked. It occurs when the task is attempted to be completed, so for a habit on clicking the plus, and happens each time it is clicked. If I edit the task to remove 'needs approval' then it behaves as normal, so I have taken it off all but one I left for troubleshooting for now.

[Alys]

The group is 96db36f3-90a5-4011-b12e-9e46a56ec1b1 (a party, although that shouldn't make a difference).
The group leader is sarahjean (Habitica Username ironorchid, 93f3cd78-3df6-484d-ae3d-fc6daebcb89c).

Here's some extra information from ironorchid / sarahjean from the Report a Bug guild:

"it is every time [that a group member clicks on a task that needs approval] but it then seems to revert the damages. It is when trying to mark the task as complete, the checkbox or plus icon for habits."

One affected player is AlphaAnt (bea6375c-6d27-4d34-be64-0d1dd398f0fe).

I have confirmed using Amplitude that AlphaAnt's account has NOT gone through avatar death since the account was created.
I.e., this bug is not causing actual death. It's apparently just making it look to the affected player as if they had died.

I've confirmed that AlphaAnt is using iOS.

Here is one of the tasks that causes the problem:

{
	"_id" : "69b03e61-f5ff-4240-8451-23e1baa757cf",
	"challenge" : { },
	"group" : {
		"approval" : {
			"required" : true,
			"approved" : false,
			"requested" : false
		},
		"assignedUsers" : [
			"bea6375c-6d27-4d34-be64-0d1dd398f0fe"
		],
		"sharedCompletion" : "singleCompletion",
		"id" : "96db36f3-90a5-4011-b12e-9e46a56ec1b1",
		"managerNotes" : ""
	},
	"completed" : true,
	"collapseChecklist" : false,
	"type" : "todo",
	"notes" : "",
	"tags" : [ ],
	"value" : -2.079244230667636,
	"priority" : 1,
	"attribute" : "str",
	"byHabitica" : false,
	"text" : "Create an issue for Habitica Groups bug",
	"reminders" : [ ],
	"checklist" : [ ],
	"createdAt" : ISODate("2020-10-23T14:40:50.218Z"),
	"updatedAt" : ISODate("2020-10-25T12:48:49.736Z"),
	"__v" : 1
}

[Alys]

Since this doesn't seem to cause any server-side changes (i.e., no actual account death), I think it's most likely a client-side iOS bug. I'm moving this issue to the iOS repo.

[saraolson]

so to replicate this, you need to have a team leader assign a task to you that needs approval, then try to complete that task from your taskboard on the ios app?

[sarahjean]

@saraolson yeah, or for a habit click the plus icon. I am not sure if it occurs on the web side or not because neither of the group members uses the website, only the app.

[SabreCat]

Users of the mobile apps are still seeing this behavior. Maybe it's regressed somehow?