HTML page Title tag for Guilds says "Group Plans"

[Alys]

When you are viewing a Guild that does not have a Group Plan, the title says "Group Plans".
It should say "Guilds".

The two examples below are public guilds that definitely don't have Group Plans in them.

Thanks to @citrusella for reporting this.

[Alys]

@thewilloftheshadow / beinginhisshadow (2eb203f5-1b1e-4e5d-84a4-22f130a1090e) has posted technical details:

"... the Group Plans does show up for me. I went looking in the code, and saw that the section is in fact set to the wrong variable for line 504 in this file:

habitica/website/client/src/components/groups/group.vue

Lines 500 to 508 in d678eb9

	if (this.isParty) this.searchId = 'party';
	if (!this.searchId) this.searchId = this.groupId;
	await this.fetchGuild();
	this.$store.dispatch('common:setTitle', {
	section: this.$t('groupPlans'),
	subSection: this.group.name,
	});
	this.$root.$on('updatedGroup', this.onGroupUpdate);
	},

this.$store.dispatch('common:setTitle', {section: this.$t('groupPlans'), subSection: this.group.name });

"This was changed in PR #12627 which was pulled to the server today"

[thewilloftheshadow]

I can take this on (:

[Alys]

@thewilloftheshadow Fantastic, thanks. :) It's yours.

[thewilloftheshadow]

Sorry about the delay, I'm having trouble setting up my local copy so I can test and make sure the change didn't affect anything else

[paglias]

Looks like normal guilds / parties and group plans use the same component (group.vue) so we'll have to add a check on whether you're viewing the group as a group plan or not (probably by looking at whether group-plans is in the url). Note that with #12743 merged there are a couple more places to update in the component file, make sure to work on an up to date version of the develop branch.

@thewilloftheshadow let me know if you need any help

[thewilloftheshadow]

I think I got it all, but there is one space to check that I noted in the PR