-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deleted Group Plan task does not look deleted in member's task list #9842
Comments
What if we simply remove the task from the user list? I'm not a big fan of adding another option to keep the task as it adds more complexity to the sync code that we'll have to support and in this case the task only exists in the user list just because someone from the group plan has assigned it to them so I think it makes sense so remove it |
There could be good reasons to keep the task. E.g., a parent gives a child a "clean teeth" task. The child does so well at it that the parent no longer needs to keep monitoring the child. The parent deletes the task from the Group Plan. However the child is so proud of their progress that they want to keep the task with its awesome streak and keep using it to make themselves even better. The child cries when they see the task has been auto-deleted. Why do we make little children cry? :) Another use case: |
My assumption was that a deleted group plan task would be treated like a deleted challenge task. As with challenges, someone might want to keep it for their own records, because they want to continue doing it, because they've made awesome progress, etc. ( |
I don't think we should use the broken megaphone icon as the megaphone is respective to Challenges. |
Just thinking out loud... I think that adding a new icon of some sort might be confusing. At least reusing the megaphone would be a clear visual signal to users that this is a task from either a challenge or a group. If we add a new icon, it's one more thing to know -- and the megaphone isn't even universally recognised now, per my experience in Habitica Help. |
I like the idea of reusing the megaphone. The actions possible for orphaned Group Plan and Challenge tasks are the same so having the same icon makes sense to me. We could improve the current confusion with the icon and reduce future confusion by improving the on-hover text for the megaphone. |
the problem with using the megaphone is that it isn't just there when a task is broken. its used to denote a challenge task at all times. its also used within the challenge section on guilds and such when they have no challenges. the megaphone is literally an icon attached to the challenge feature. we could use a similar pattern for group plans, but using the exact icon for something other than challenges is unclear. |
Honestly, from time in Report a Bug and Habitica Help, etc, what's unclear is "lots of different ways to display basically the same thing". The simpler it can be, the better. As a new user, I'd just interpret the megaphone as being "tasks I didn't add myself", not as "challenges specifically" -- if I ever even noticed the challenge icon, which a fair number of people do not (and don't notice the broken megaphone icon either). More stuff to remember or interpret =/= necessarily clearer. |
Best approach here may be to wait until interactive task board improvements are live, see if that changes user perception of what's going on, and then survey or interview Team plan users in aggregate to ensure we develop a solution that works for them. |
It's not obvious when an assigned Group Plan task has been deleted from the Group. Steps to reproduce:
Ideally when a task has been deleted from the Group Plan, we should adjust the appearance of the tasks so that it's clear it's no longer associated with the Group Plan. For example, we could replace "You are assigned to this task Remove Claim" with something like "Task has been removed from the Group Plan's task list"
Also, it would be nice if we could have an option to convert the task to a regular user task, as we have for deleted Challenge tasks. A user might want to keep the task and won't want to always see the "has been removed" message.
FYI @Tressley for design
For the coder who implements this after a design is done, you can identify a deleted Group Plan task by
"broken": "TASK_DELETED"
in the user's copy of it. Example:If the user chooses to keep the task the
group
section of the task would need to be changed to the default settings:The text was updated successfully, but these errors were encountered: