Reset account. Tasks are removed but the challenges still remain

[Algogator]

1. Join a challenge(s)
2. Reset account

Expected: Previously joined challeneges should have been removed
Actual results: Challenges accepted before the reset are still in list https://habitrpg.com/#/options/groups/challenges

edit: Completed quests aren't reset as well

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[Alys]

HabitRPG/habitrpg-shared#323

[waldofe]

There's someone working on it? I would love to give it a go. @Alys, I was reading your comment on the old repo issue and it looks like there's some doubt about which challenges should be removed from the user. I think that would be good to:

• Remove the challenges that I do not manage.
• Improve messages on "Reset" modal.

I still didn't setup the project yet, but what about the statements above?

/cc @theCodegator

[Alys]

I think if we're going to remove challenge tasks, we should remove all of them, even the ones that the player manages. They can always rejoin their own challenges later. The consistency will make the feature easier to explain in the help text, wiki, etc.

In the old pull request, I wrote this, which is utter nonsense: "We also need to consider what happens when the user is the creator of a challenge. After a reset, they must still be able to administer the challenge. In that case, it's probably best to not remove them from the challenge at all." A challenge creator can still manage a challenge without being a participant, so just ignore that comment. Sorry about the confusion. :)

Similarly, challenge tags should be removed regardless of whether the player is the challenge creator or not.

However before proceeding, we should make sure that we do actually want to remove challenge tasks when a player clicks the "reset" button, even when the player has made significant progress in the challenge. @lemoness - is this okay to do?

[waldofe]

Thanks for the answer @Alys. On my point of view, it makes no sense to keep those challenges, I mean, it's an account reset after all. But let's see.. 👍

[paglias]

Fixed in v3