Added force sync param to party and tavern requests #7437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I have a few adjustments I'm making. |
|
To the API-v3 branch? |
|
To this PR. |
|
Closing this. Re-open it against the |
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| habitrpg.controller("TavernCtrl", ['$scope', 'Groups', 'User', 'Challenges', | |||
| function($scope, Groups, User, Challenges) { | |||
| Groups.tavern() | |||
| Groups.tavern(true) | |||
There was a problem hiding this comment.
We shouldn't force a lookup of the Tavern every time, that'd be a lot of requests.
I think the source of the chat bug is that the cached version of the Tavern isn't persisting the new messages that get added.
|
@crookedneighbor Are you able to replicate the tavern part of this bug locally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7407
Changes
I have forced the sync every time you are on the party/tavern page. This should help update chat and prevent the need for reloads.
UUID: