Add villagers #48
Merged
Add villagers #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 313dd12): https://habitatheroes--pr48-jingying-last-change-pylvo1ql.web.app (expires Mon, 21 Mar 2022 06:38:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Poor Mr U Thein Naing - got evicted and replaced by Mr Phlen almost immediately after securing his house. |
|
zhuhanming
reviewed
Mar 14, 2022
src/reducers/houseReducer.js
Outdated
| @@ -10,7 +10,7 @@ export const BuildTime = { | |||
| // in seconds | |||
| basic_hut: 10, // original time is 129600 (36 hours) | |||
| brick_house: 20, // original time is 259200 (72 hours) | |||
| concrete_house: 10860, // original time is 518400 (144 hours) | |||
| concrete_house: 5, // original time is 518400 (144 hours) | |||
There was a problem hiding this comment.
Is this intended? Should be 3 hours right
There was a problem hiding this comment.
Right!! Ps was shortening the duration for testing
zhuhanming
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Hut Villager:
Screen.Recording.2022-03-14.at.1.48.57.PM.mov
Brick House Villager:
Cambodia.mov
Concrete House Villager:
Batam.mov