Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding default values fails when "XSRF Protection" is enabled #12

Closed
alindeman opened this issue Feb 10, 2016 · 2 comments
Closed

Adding default values fails when "XSRF Protection" is enabled #12

alindeman opened this issue Feb 10, 2016 · 2 comments

Comments

@alindeman
Copy link
Contributor

If "XSRF Protection" is enabled in Bamboo -> Configuration -> Security -> Security Settings, this plugin causes an error when viewing the Miscellaneous build config tab for the first time

java.lang.IllegalStateException: XSRF: A mutative operation was attempted on DefaultChain within a non-mutative HTTP request: https://bamboo.example/chain/admin/config/editChainMiscellaneous.action?buildKey=PDT-PJHM

It's not allowed to call mutative operations on GET requests (e.g., savePlanAndDefinition) when XSRF Protection is enabled.

Is there a way to fix the bug that this code was intended to fix without mutating on a GET request?

@HackAttack
Copy link
Owner

Crap. I will release a new version that reverts this change, then investigate. This has been a tricky bug—working with the UI layer is not particularly intuitive.

@HackAttack
Copy link
Owner

Reverted the defective fix and reopened the original bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants