This repository has been archived by the owner on Feb 5, 2024. It is now read-only.
Moar lcs #3
Merged
Moar lcs #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh wait it says @dhruvilp did it. idk how my master had it and not upstream ?!?!? |
wait, what? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds basically the rest of the lcs interaction we need and a bunch of error checking
it also adds a tests file that i used to run tests on this stuff without a ui.
it is important to check if the user is a director before scanning because of a current issue in lcs.
i don't remember typing that thing about the linter. I blame qasim