Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

QR scanner business logic #64

Closed
dhruvilp opened this issue Feb 2, 2020 · 1 comment
Closed

QR scanner business logic #64

dhruvilp opened this issue Feb 2, 2020 · 1 comment
Assignees
@PJprogrammer
Labels
bug Something isn't working good first issue Good for newcomers
Projects
HackRU Spring 2020
Milestone
Android & iOS App...

Comments

@dhruvilp
Copy link
Collaborator

dhruvilp commented Feb 2, 2020

Describe the bug
QR Scanner was making 2 requests per scan to the DB (maybe fixed now but double check)

To Reproduce
Steps to reproduce the behavior:

  1. Open the scanner and scan a QR code
  2. Insert a print statement to ensure how many requests we're making per scan

Expected behavior
Should only make 1 request per QR code scan

Additional context
We might implement the BloC pattern for QR Scanner so do research on Flutter BloC and implement it so we could avoid this kind of bugs.
@dhruvilp dhruvilp added the bug Something isn't working label Feb 2, 2020
@dhruvilp dhruvilp added this to To do in HackRU Spring 2020 via automation Feb 2, 2020
@dhruvilp dhruvilp added this to the Android & iOS App Deployment milestone Feb 2, 2020
@dhruvilp dhruvilp added the good first issue Good for newcomers label Feb 2, 2020
@shivanmodha
Copy link
Member

Done!

HackRU Spring 2020 automation moved this from To do to Done Mar 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@PJprogrammer PJprogrammer

Labels
bug Something isn't working good first issue Good for newcomers
Projects
HackRU Spring 2020
  
Done
Milestone
Android & iOS App Deployment
Development

No branches or pull requests
3 participants
@PJprogrammer @shivanmodha @dhruvilp