Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bermarte: Asynchronous-programming #290

Open
36 of 88 tasks
bermarte opened this issue Feb 3, 2021 · 9 comments
Open
36 of 88 tasks

Bermarte: Asynchronous-programming #290

bermarte opened this issue Feb 3, 2021 · 9 comments

Comments

@bermarte
Copy link
Member

bermarte commented Feb 3, 2021

module repository

Suggested Study

expand/collapse

Closure & Callstack

The Event Loop

Callbacks, Promises, Async

APIs

fetch

Node.js

Other

take your frontend skills above and beyond:


Week 1

  • Sunday Prep
  • Sunday Class

Project

  • repo (with a complete README)
  • live demo
  • Planning
  • Implementation
    • ES Modules (import/export)
    • at least one class
    • at least one setTimeout and one setInterval
    • Logs of each user interaction

Check-In

Progress

  • Worked a bit more on the previous assignment
  • watching tutorials
    Blocked
    - closure
    Next Steps
  • understand closure
  • working on the exercises
  • working on the project
    Tip(s) of the week
    I forgot how to Strikethrough with GitHub Markdown ~~text~~

Week 2

  • Sunday Prep
  • Sunday Class

Project

Check-In

Progress

  • Completed the previous assignment
    Blocked
    Next Steps
  • Working on the previous project
  • Working on the project of the week
  • Maybe working on the exercises
    Tip(s) of the week

Week 3

  • Sunday Prep
  • Sunday Class

Project

group project

Check-In

Progress

@bermarte bermarte added this to the asynchronous-programming milestone Feb 3, 2021
@bermarte bermarte changed the title Your Name: Module Name Bermarte: Asynchronous-programming Feb 3, 2021
@bermarte bermarte added the week-1 label Feb 3, 2021
@bermarte bermarte self-assigned this Feb 3, 2021
@colevandersWands
Copy link
Contributor

@bermarte , do you have any specific questions about closure that I could help with?

@bermarte
Copy link
Member Author

bermarte commented Feb 3, 2021

@bramdevries bramdevries added this to READY FOR REVIEW: You've merged all the 'must-have' PRs in 9. Asynchronous Programming Feb 7, 2021
@bermarte bermarte moved this from READY FOR REVIEW: You've merged all the 'must-have' PRs to IN PROGRESS: Moving issues, reviewing PRs, all the fun stuff in 9. Asynchronous Programming Feb 8, 2021
@bermarte
Copy link
Member Author

bermarte commented Feb 9, 2021

@bramdevries and @ThibaultLesuisse I am not satisfied with the code, but I want to go a little further with my pomofocus. Anyway, I'll create a new simplified one from scratch and rewrite it without using global variables.

@bermarte bermarte moved this from IN PROGRESS: Moving issues, reviewing PRs, all the fun stuff to READY FOR REVIEW: You've merged all the 'must-have' PRs in 9. Asynchronous Programming Feb 9, 2021
@bramdevries
Copy link
Contributor

That's totally fine! Refactoring based on new things you've learned is a part of the development process!

@colevandersWands
Copy link
Contributor

@bermarte, I just noticed I missed your mention about closure. How are you doing with that? Do you still have questions about it?

@bermarte
Copy link
Member Author

bermarte commented Feb 9, 2021

@colevandersWands thanks, I think I will come back to the subject in the future, to understand it better. Bram gave an example of calling a function inside a function (something like fun(arg1)(arg2))) which is interesting. I don't know what the name of that concept is. Then I was wondering how to call a method inside a method in a class.

@colevandersWands
Copy link
Contributor

methods inside methods and functions inside functions work differently even if they look the same. putting that aside for now isn't a bad idea

@bermarte bermarte moved this from READY FOR REVIEW: You've merged all the 'must-have' PRs to PLANNING: backlog, dev strategy, issues, ... in 9. Asynchronous Programming Feb 10, 2021
@bermarte bermarte moved this from PLANNING: backlog, dev strategy, issues, ... to READY FOR REVIEW: You've merged all the 'must-have' PRs in 9. Asynchronous Programming Feb 12, 2021
@bramdevries
Copy link
Contributor

Really nice job with the portfolio. It looks really modern and I like the small animations!

  • Your Repo class currently handles the loading of all the repositories that you want. A class should be as small as possible, in this case a single repository.
  • Nice job on already using async/await syntax for this project.
  • Your data fetching code is currently modifying the global repos variable. This will have the side-effect that if you ever call repo.getRepos a second or third time you'll have the same repositories included twice.
  • On your projects section you're filtering the list of projects to a certain selection. But what would happen if you started creating more repositories and the ones you want to display are no longer returned because GitHub's API paginates the list of repositories? Since you already know the names of the repositories you want to include you could also use this endpoint to retrieve them individually. This is also a good way to experiment a bit with concurrent requests using Promise.all

@bramdevries bramdevries moved this from READY FOR REVIEW: You've merged all the 'must-have' PRs to NEEDS REVISION: A coach or an alumni have spotted some improvements in 9. Asynchronous Programming Feb 13, 2021
@bermarte
Copy link
Member Author

bermarte commented Feb 14, 2021

@bramdevries Thank you, Bram, I appreciate your feedback. I will refactor it following your input.

@bermarte bermarte moved this from NEEDS REVISION: A coach or an alumni have spotted some improvements to READY FOR REVIEW: You've merged all the 'must-have' PRs in 9. Asynchronous Programming Feb 15, 2021
@bramdevries bramdevries moved this from READY FOR REVIEW: You've merged all the 'must-have' PRs to DONE: A coach or alumni has approved your project! in 9. Asynchronous Programming Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
9. Asynchronous Programming
DONE: A coach or alumni has approved ...
Development

No branches or pull requests

3 participants