Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component - Button #264

Closed
KevinTss opened this issue Feb 26, 2023 · 2 comments · Fixed by #282
Closed

Component - Button #264

KevinTss opened this issue Feb 26, 2023 · 2 comments · Fixed by #282
Assignees

Comments

@KevinTss
Copy link
Contributor

KevinTss commented Feb 26, 2023

Button

Specifications

  • Should render a <button> HTML element
  • There are 2 sizes: small and medium
  • There are 3 variants: default, primary, secondary
    • Default: Has transparent background and only a visible background on hover
    • Primary: Has the primary color
    • Secondary: Has an opacity on the background and no primary color
  • Color

Helpers

button {
  /* Small size */
  padding: 10px 24px;
  gap: 10px;

  /* Medium size */
  padding: 10px 32px;
  gap: 16px;

  /* Default variant */
  background: #295BF6;
  /* On hover for default */
  background: rgba(255, 255, 255, 0.1);

  /* Secondary variant */
  background: rgba(255, 255, 255, 0.1);

  /* Common */
  border-radius: 8px;
  color: #FFFFFF;
}

We should use it as this:

import { Button } form '...'

const Component = () => (
  <div>
    <Button onClick={...}>
      Discover more
      <RightArrowIcon />
    </Button>
  </div>
)

Images

Image
Image
Image
Image

@sebherrerabe
Copy link
Contributor

Is there a reason you mentioned 3 differents variants in the description and then in the helper you only put 2 ?

@KevinTss
Copy link
Contributor Author

Is there a reason you mentioned 3 differents variants in the description and then in the helper you only put 2 ?

You're right is not clear

Here are the 3 variants:
Screenshot 2023-03-19 at 11 45 12

As you can see on the top menu is the default variant -> Transparent background (secondary background on hover)
On the header your can see those:
Primary -> Purple like background
Secondary -> Grey like background

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants