Time selector close #1169
Merged
Time selector close #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2017 12:48
Don't close picker when only date is selected
willm
force-pushed
the
time-selector-close
branch
from
7ab731e
to
d1fe6e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1169 +/- ##
==========================================
- Coverage 86.38% 86.04% -0.34%
==========================================
Files 13 13
Lines 852 853 +1
Branches 143 144 +1
==========================================
- Hits 736 734 -2
- Misses 31 33 +2
- Partials 85 86 +1
Continue to review full report at Codecov.
|
Squar89
pushed a commit
to Squar89/react-datepicker2
that referenced
this pull request
Apr 10, 2019
* Only focus when input has a focus method * When time picker is displayed close picker when time is selected Don't close picker when only date is selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the time selector is displayed, only close the picker when a time is selected (issue described in #1149)
Also, when passing in a custom input element, don't try and call a non existent
focus()function #636