Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of "excludeScrollbar" parameter from react-onclickoutside #2031

Closed
dan-diaz opened this issue Jan 27, 2020 · 1 comment
Closed

Make use of "excludeScrollbar" parameter from react-onclickoutside #2031

dan-diaz opened this issue Jan 27, 2020 · 1 comment
Labels

Comments

@dan-diaz
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When clicking on the scrollbar to scroll a page, onClickOutside is triggered and closes the datepicker.

Describe the solution you'd like
react-onclickoutside offers the excludeScrollbar parameter to ignore scrollbar clicks.
I'm working on a Pull Request right now to enable this parameter and set as true by default.

Describe alternatives you've considered
none

Additional context
This parameter is only in effect when the user's screen has scrollbars constantly visible.
If your scrollbars hide automatically, a click in their area does not count as a scrollbar click and will still trigger onClickOutside. And this is because of how react-onclickoutside compares the click coordinates to the documentElement. And documentElement clientWidth/clientHeight are different depending on your default scrollbar settings.

@stale
Copy link

stale bot commented Jul 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 25, 2020
@stale stale bot closed this as completed Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant