Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option "required" should be typed as a boolean, not as a string #4899

Closed
alexey-m-ukolov opened this issue Jun 14, 2024 · 2 comments
Closed

Option "required" should be typed as a boolean, not as a string #4899

alexey-m-ukolov opened this issue Jun 14, 2024 · 2 comments

Comments

@alexey-m-ukolov
Copy link

Describe the bug
Commit #6fe84be introduced DatePickerProps type in which the required property is typed as a string.

Expected behavior
This option should be typed as a boolean as it stated in the docs.
@tomekpiwowar
Copy link

I agree with @alexey-m-ukolov.
Even though the DatePicker component itself is not a form element, the required attribute is typically used in the context of form validation and its expected type in HTML is boolean.

@alexey-m-ukolov alexey-m-ukolov changed the title Option "required" should be typed as boolean, not a string Option "required" should be typed as a boolean, not as a string Jun 14, 2024
@yuki0410-dev yuki0410-dev mentioned this issue Jun 17, 2024
Merged
3 tasks
@martijnrusschen
Copy link
Member

Should be solved with #4905

@nick-heard nick-heard mentioned this issue Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martijnrusschen @alexey-m-ukolov @tomekpiwowar