Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing hints using pydantic #46

Open
roysti10 opened this issue Dec 17, 2020 · 2 comments
Open

Typing hints using pydantic #46

roysti10 opened this issue Dec 17, 2020 · 2 comments
Assignees
@roysti10
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@roysti10
Copy link
Member

roysti10 commented Dec 17, 2020 •
edited

Is your feature request related to a problem? Please describe.
Add type hints to the files inside fantasy_cricket.
using pydantic and typing
Additional context
It would also be great if mypy was used for the checks and added to the CI
@roysti10 roysti10 added enhancement New feature or request good first issue Good for newcomers labels Dec 17, 2020
@scientes
Copy link
Contributor

pydantic and typing are a good Start for type hints and type checking

@roysti10
Copy link
Member Author

pydantic seems like a solid choice for this.
FastApi is also based on pydantic so seems like a solid choice to me

Thx for the suggestion

@roysti10 roysti10 changed the title Typing hints Typing hints using pydantic Dec 18, 2020
@roysti10 roysti10 self-assigned this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roysti10 roysti10

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scientes @roysti10