Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added api for Users #7

Closed
wants to merge 1 commit into from
Closed

Conversation

HenryZerocool
Copy link

#4

  • Added requirement.txt fpr installation
  • Added 2 APIs as requested

Please test it because I'm new to opensource, and it might not work for you.
Thanks

@WesGtoX WesGtoX assigned WesGtoX and HenryZerocool and unassigned WesGtoX Oct 31, 2020
@WesGtoX WesGtoX added enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted Accept for hacktoberfest, will merge later labels Oct 31, 2020
@WesGtoX WesGtoX linked an issue Oct 31, 2020 that may be closed by this pull request
3 tasks
@WesGtoX
Copy link
Member

WesGtoX commented Nov 3, 2020

Hi @HenryZerocool, sorry for the delay, but I had already accepted your pull request for the hacktoberfest, I tested its implementation and I have some considerations.

  • The library you use is deprecated, so I would recommend using this Simple JWT.
  • Regarding the dependencies, I saw that you created a requirements.txt, but we are using Poetry with Docker and Docker Compose that makes it easier to manage the dependencies and test the application.
  • I didn't configure the CI to run with a pull request, but I'll fix it.
  • In its implementation, no tests were performed to ensure that everything was working correctly.

As I said, I need to make some fixes to the environment and template patterns to make it easier to receive contributions.

If you told me you can correct these considerations, I am waiting for your response and I can even help you.

But if you prefer, I can make changes for you and update in the repository.

I await your response and thanks for the contribution!

@WesGtoX WesGtoX closed this Nov 16, 2020
@WesGtoX
Copy link
Member

WesGtoX commented Nov 16, 2020

Solved by #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted Accept for hacktoberfest, will merge later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an api for user registration and login with jwt authentication
2 participants