Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name should be trimmed #16

Closed
burakkilic opened this issue Nov 30, 2017 · 2 comments
Closed

Name should be trimmed #16

burakkilic opened this issue Nov 30, 2017 · 2 comments
Labels
bug

Comments

@burakkilic
Copy link

Hi,

I was setting ngx-avatar's name attribute to my user's Full Name. I get some errors like toUpper case is not a function. Then I realized ngx-avatar splitting the name by whitespace, and some of my users have whitespace in leading in their names. So an error occurs.

Maybe I am the one who should trim the name before saving to the db but also it can be added to the library.

Thank you
@HaithemMosbahi
Copy link
Owner

Hi,
Thank you for raising this issue. Yes I agree with you, this should be added to the library. I will fix this asap.

@HaithemMosbahi
Copy link
Owner

Hi,
Sorry for my late reply, I was too busy. I just published a new version ( 2.9.0 ) which includes the commit that fixes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@burakkilic @HaithemMosbahi