You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ykawashima raised this issue on Slack. When computing the cross section using the MODIT and CH4/ExoMol, Yui found a significant increase of the cross section at the edges of the wavenumber grid, such as
I found the reason of this phenomena. First, when picking the lines up, moldb has margin=1.0 nm as default value outside the wavenumber grid. This implementation was for the direct LPF considering the lines outside of the wavenumber bin leak in the wavenumber grid.
But, for MODIT, it causes some problems: i.e. the lines whose the line center is outside of the wavenumber bin contirbute to the opacity at the edge of the wavenumber bins. See the line strength distribution of CH4:
The wavenumber grid was 11890-11950AA. Then lines in 11889-11890AA contributed to the left edge and those in 11950-11951AA did to the right edge.
So, I fixed this problem by
set default margin=0.0 in moldb
added Warning when some of the line center is outside of the wavenumber grid
But, still be careful for the results. In this implementation, we intentionally ignore the contribution of the lines outside of the wavenumber bins. So, you might use the wavenumber grid larger than your interest. So, in this case, the result becomes like
The text was updated successfully, but these errors were encountered:
@ykawashima raised this issue on Slack. When computing the cross section using the MODIT and CH4/ExoMol, Yui found a significant increase of the cross section at the edges of the wavenumber grid, such as
I found the reason of this phenomena. First, when picking the lines up, moldb has margin=1.0 nm as default value outside the wavenumber grid. This implementation was for the direct LPF considering the lines outside of the wavenumber bin leak in the wavenumber grid.
But, for MODIT, it causes some problems: i.e. the lines whose the line center is outside of the wavenumber bin contirbute to the opacity at the edge of the wavenumber bins. See the line strength distribution of CH4:
The wavenumber grid was 11890-11950AA. Then lines in 11889-11890AA contributed to the left edge and those in 11950-11951AA did to the right edge.
So, I fixed this problem by
But, still be careful for the results. In this implementation, we intentionally ignore the contribution of the lines outside of the wavenumber bins. So, you might use the wavenumber grid larger than your interest. So, in this case, the result becomes like
The text was updated successfully, but these errors were encountered: