fixes 127 - bug with failure-condition option

phpmetrics · Apr 1, 2015 · d19b81b · d19b81b
1 parent a3f8fd1
commit d19b81b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/src/Hal/Application/Command/RunMetricsCommand.php b/src/Hal/Application/Command/RunMetricsCommand.php
@@ -124,7 +124,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
         // evaluation of success
         $evaluator = new Evaluator($collection, $aggregatedResults, $bounds);
         $result = $evaluator->evaluate($config->getFailureCondition());
-        return $result->getCode();
+        // fail if failure-condition is realized
+        return $result->isValid() ? 1 : 0;
     }
 
 }
diff --git a/src/Hal/Application/Config/ConfigFactory.php b/src/Hal/Application/Config/ConfigFactory.php
@@ -53,6 +53,7 @@ public function factory(InputInterface $input) {
         strlen($input->getOption('report-csv')) > 0     && $config->getLogging()->setReport('csv', $input->getOption('report-csv'));
         strlen($input->getOption('violations-xml')) > 0 && $config->getLogging()->setViolation('xml', $input->getOption('violations-xml'));
         strlen($input->getOption('chart-bubbles')) > 0  && $config->getLogging()->setChart('bubbles', $input->getOption('chart-bubbles'));
+        strlen($input->getOption('failure-condition')) > 0  && $config->setFailureCondition($input->getOption('failure-condition'));
 
         return $config;
 

diff --git a/src/Hal/Component/Evaluation/Evaluation.php b/src/Hal/Component/Evaluation/Evaluation.php
@@ -19,14 +19,6 @@ class Evaluation
 
     private $valid = true;
 
-    /**
-     * @return int
-     */
-    public function getCode()
-    {
-        return $this->valid === true ? 0 : 1;
-    }
-
     /**
      * @param boolean $valid
      * @return $this