Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing --provider and URL without the '/' suffix gives an invalid link #70

Closed
tmplt opened this issue Sep 10, 2016 · 2 comments
Closed

Comments

@tmplt
Copy link
Contributor

tmplt commented Sep 10, 2016

Present in e8a4bfb.

The shortid seems to be appended to the --provider string, so if the provider isn't suffixed with '/', an invalid link is printed.

Example:

$ pbpst -Sf file.png --provider=https://ptpb.pw
https://ptpb.pw<shortid> # invalid

Expected:

$ pbpst -Sf file.png --provider=https://ptpb.pw
https://ptpb.pw/<shortid> # valid
@HalosGhost
Copy link
Owner

Thanks for the heads-up. There's already a code-block to ensure that the provider gets a trailing slash, I imagine it is being skipped over in the case where the user has passed a provider, so all this should require is to make sure that verification is run regardless.

@HalosGhost
Copy link
Owner

via 3d26713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants