wrong \move callback - easycomm_rot_move_velocity

[rubienr]

rotctl (Easycomm 3) registers wrong callback for the \move command:

Hamlib/rotators/easycomm/easycomm.c

Line 647 in 4a61832

.move = easycomm_rot_move_velocity,

How to reproduce:

1. create a pipe with endpoints ./a and ./b: socat -d -d pty,raw,echo=0,link=./a pty,raw,echo=0,link=./b
2. listen to pipe: cat ./a
3. start rotctl: rotctl --model=204 --rot-file=./b

• \move 2 100 sends VU9900
• \move 4 100 sends VD9900
• \move 8 100 sends VL9900
• \move 16 100 sends VR9900

Expected behaviour:

• \move 2 100 sends MU VU9900
• \move 4 100 sends MD VD9900
• \move 8 100 sends ML VL9900
• \move 16 100 sends MR VR9900

Other observation:

• start rotctl: rotctl --model=202 --rot-file=./b (Easycomm 2)
  • \move 2 100 sends MU, expected MU VU9900
  • \move 4 100 sends MD, expected MD VD9900
  • \move 8 100 sends ML, expected ML VL9900
  • \move 16 100 sends MR, expected MR VR9900

Observed in version:

$ rotctl --version
rotctl(d), Hamlib 4.0

Copyright (C) 2000-2012 Stephane Fillod
Copyright (C) 2000-2003 Frank Singleton
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.