-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.9.58 #1546
Comments
These are all things I've already started or assigned to me, so this is more to serve as a reminder so they don't get forgotten. Again. edit: to clarify, forgotten by me; didn't intend to disparage anyone else's contributions or suggestions, but upon rereading, I thought it sounded bad... |
Not specific to the release, but relevant to the work that will produce it... I'd like to propose that we put changelog messages in our commit messages.
I hope this doesn't seem onerous - at least part of the motivation for doing this is that I think I'm missing out on highlighting some of our work, by not recognising its importance/effects from the commit message. I'm also happy to consider changing the message format - e.g. it might be nice to include names :) |
Not opposed to the idea... have you submitted any recently that can be reviewed to make sure I understand exactly what you have in mind? |
Not as commits, but check out our release notes, for loads of the sorts of thing I’m looking for. |
And I guess we’ll need a delimiter, so maybe a line that looks like this: CL: *Added*: hs.foo.bar() |
Some plan on tackling complex monitor layouts (e.g. one found in #1522) would be nice. |
@cmsj, I'm not up on the innermost details of git; is that 50 char limit the web site recommends a hard limit (i.e. is the text itself split into multiple fields or lines) or is that just a formatting limitation where only the first 50 chars are used by some git internals? Basically do our messages have to be short (and potentially unclear) -- like the one I just did for hs.battery.getAll -- or can we ignore the 50 char limit? Or do we put it into the lower section when updating via the web site? |
@asmagill there's no hard limit. Ideally the changelog messages would be pretty short, but if they do need to be longer, it's fine :) |
@asmagill one comment on the battery one though - in isolation the message doesn't tell people what really changed - I would have put I've also tended to use an active, future-oriented voice, so something like "foo should no longer crash when X and Y". (The actual reality here is that any kind of |
Yep, ignore it. It’s just a convention to keep the first line of the commit message short. Git doesn’t care 🙂 |
Ok, it's been unnecessarily long since I opened this issue. Let's revisit the idea of getting 0.9.58 out, preferably prior to Christmas. So, any nominations for things that actually have a decent chance of being fixed/landed in the next ~2 weeks? :) |
Once @asmagill has tested it I think we can put
I would LOVE to see Other issues that could be addressed/closed if anyone's eager:
Things that I'll get to... eventually, but not before Christmas:
|
I will let you know tomorrow what I've been working on that I think I can have release ready in time -- my availability until late Jan is going to be sporadic, so I want to do a review before promising anything. |
Sorry guys, I've had much less time then I anticipated and it probably won't get any better until sometime in January. The guitk is probably safe enough, but it's a huge addition -- something like 10 separate modules so that its various components can be mixed-and-matched in a variety of ways, so i'd really like to get some more documentation ready before unleashing it on the world. Canvas will need some tweaks to integrate fully (it mostly works but not with all of the placement options the guitk manager offers), which I still need to work out. The menubar addition (and replacement wrapper for I will make a point to look at hs.midi in a day or so; I doubt there is any reason it can't be included in the upcoming release. |
No worries at all! The work you do is HUGELY appreciated - thank you, thank you.
I'm planning to start using CommandPost might be a good testing ground for the extension, before you commit it to Hammerspoon.
Legend, thank you! I've been using Oh, and I'll get you the best belated Christmas present in the world if you add "notifications" to |
And done :) |
No specific timelines in mind, just a tracking bug for y'all to list the things you'd like to see/do in 0.9.57 :)
The text was updated successfully, but these errors were encountered: