Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.9.58 #1546

Closed
cmsj opened this issue Sep 15, 2017 · 18 comments
Closed

Release 0.9.58 #1546

cmsj opened this issue Sep 15, 2017 · 18 comments
Assignees
Milestone

Comments

@cmsj
Copy link
Member

cmsj commented Sep 15, 2017

No specific timelines in mind, just a tracking bug for y'all to list the things you'd like to see/do in 0.9.57 :)

@cmsj cmsj added this to the 0.9.57 milestone Sep 15, 2017
@cmsj cmsj self-assigned this Sep 15, 2017
@latenitefilms
Copy link
Contributor

latenitefilms commented Sep 15, 2017

My Wishlist for 0.9.57:

@asmagill
Copy link
Member

asmagill commented Sep 15, 2017

These are all things I've already started or assigned to me, so this is more to serve as a reminder so they don't get forgotten. Again.

edit: to clarify, forgotten by me; didn't intend to disparage anyone else's contributions or suggestions, but upon rereading, I thought it sounded bad...

@cmsj
Copy link
Member Author

cmsj commented Sep 16, 2017

Not specific to the release, but relevant to the work that will produce it... I'd like to propose that we put changelog messages in our commit messages.

  • Not every commit needs a changelog message, just one per:
    • bug fix
    • API additions
    • module additions
    • API behaviour modified
  • Changelog messages must be a single line
  • Each message should start with "*Fixed*:", "*Added*:", "*Changed*:"

I hope this doesn't seem onerous - at least part of the motivation for doing this is that I think I'm missing out on highlighting some of our work, by not recognising its importance/effects from the commit message.

I'm also happy to consider changing the message format - e.g. it might be nice to include names :)

@asmagill
Copy link
Member

Not opposed to the idea... have you submitted any recently that can be reviewed to make sure I understand exactly what you have in mind?

@cmsj
Copy link
Member Author

cmsj commented Sep 16, 2017

Not as commits, but check out our release notes, for loads of the sorts of thing I’m looking for.

@cmsj
Copy link
Member Author

cmsj commented Sep 16, 2017

And I guess we’ll need a delimiter, so maybe a line that looks like this:

CL: *Added*: hs.foo.bar()

@farcaller
Copy link

Some plan on tackling complex monitor layouts (e.g. one found in #1522) would be nice.

@asmagill
Copy link
Member

@cmsj, I'm not up on the innermost details of git; is that 50 char limit the web site recommends a hard limit (i.e. is the text itself split into multiple fields or lines) or is that just a formatting limitation where only the first 50 chars are used by some git internals? Basically do our messages have to be short (and potentially unclear) -- like the one I just did for hs.battery.getAll -- or can we ignore the 50 char limit? Or do we put it into the lower section when updating via the web site?

@cmsj
Copy link
Member Author

cmsj commented Sep 19, 2017

@asmagill there's no hard limit. Ideally the changelog messages would be pretty short, but if they do need to be longer, it's fine :)

@cmsj
Copy link
Member Author

cmsj commented Sep 19, 2017

@asmagill one comment on the battery one though - in isolation the message doesn't tell people what really changed - I would have put hs.battery.getAll() rather than just getAll.

I've also tended to use an active, future-oriented voice, so something like "foo should no longer crash when X and Y".

(The actual reality here is that any kind of CL message at all, helps me, so nobody needs to get too hung up on sounding exactly like my editorial voice :)

@asmagill
Copy link
Member

Just to confirm, ignore the "suggestion" about 50 chars that is popped up when doing an edit directly through the web site, correct? e.g.

screen shot 2017-09-19 at 9 07 01 am

@cmsj
Copy link
Member Author

cmsj commented Sep 19, 2017

Yep, ignore it. It’s just a convention to keep the first line of the commit message short. Git doesn’t care 🙂

@cmsj cmsj changed the title Release 0.9.57 Release 0.9.58 Oct 16, 2017
@cmsj
Copy link
Member Author

cmsj commented Dec 11, 2017

Ok, it's been unnecessarily long since I opened this issue. Let's revisit the idea of getting 0.9.58 out, preferably prior to Christmas.

So, any nominations for things that actually have a decent chance of being fixed/landed in the next ~2 weeks? :)

@latenitefilms
Copy link
Contributor

Once @asmagill has tested it hs.midi should be pretty good to go. We have about 559 active monthly users running CommandPost, and we've had hs.midi included for the last couple of beta's and it hasn't exploded the world, so it should be safe for the Hammerspoon community too.

I think we can put hs.dialog.font on the back-burner for the foreseeable future until someone can come up with a suitable fix.

hs.guitk will solve a lot of my hs.menubar issues (#1045, #1567, #914, #1229, #1057 and #974) when it's ready for primetime, which is awesome! Not sure if @asmagill will have it ready before Christmas however, but fingers crossed!

I would LOVE to see hs.plist.edit() & NSKeyedArchiver support (#1498) competed - but I'd imagine @asmagill already has more than enough on his plate.

Other issues that could be addressed/closed if anyone's eager:

Things that I'll get to... eventually, but not before Christmas:

@asmagill
Copy link
Member

I will let you know tomorrow what I've been working on that I think I can have release ready in time -- my availability until late Jan is going to be sporadic, so I want to do a review before promising anything.

@asmagill
Copy link
Member

Sorry guys, I've had much less time then I anticipated and it probably won't get any better until sometime in January.

The guitk is probably safe enough, but it's a huge addition -- something like 10 separate modules so that its various components can be mixed-and-matched in a variety of ways, so i'd really like to get some more documentation ready before unleashing it on the world. Canvas will need some tweaks to integrate fully (it mostly works but not with all of the placement options the guitk manager offers), which I still need to work out.

The menubar addition (and replacement wrapper for hs.menubar) to it is coming along nicely and can accept drag-and-drop items, but only to the status icon -- don't have it so you can drag to a specific menu item yet (though I think I'm close). I'll review the list of menubar issues you've listed above -- I think I've addressed most of them with guitk/menubar but I'll check when I do get a chance to get back to it.

I will make a point to look at hs.midi in a day or so; I doubt there is any reason it can't be included in the upcoming release.

@latenitefilms
Copy link
Contributor

Sorry guys, I've had much less time then I anticipated and it probably won't get any better until sometime in January.

No worries at all! The work you do is HUGELY appreciated - thank you, thank you.

The guitk is probably safe enough, but it's a huge addition

I'm planning to start using guitk in CommandPost soon, so that we can really put it through its paces - especially the menubar addition.

CommandPost might be a good testing ground for the extension, before you commit it to Hammerspoon.

I will make a point to look at hs.midi in a day or so; I doubt there is any reason it can't be included in the upcoming release.

Legend, thank you! I've been using hs.midi on several machines with CommandPost for a few weeks now, and it seems very stable, which is good!

Oh, and I'll get you the best belated Christmas present in the world if you add "notifications" to hs._asm.axuielement in the New Year! This is one feature that would offer HUGE amounts of benefits to my crazy CommandPost project once it's done. If only we could clone you...

@cmsj
Copy link
Member Author

cmsj commented Dec 25, 2017

And done :)

@cmsj cmsj closed this as completed Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants