New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors are brighter when using H.264 (AMD VCE) compared to H.264 (x264) or original #2946
Comments
Indeed, that looks brighter. The cropping filter is active. You can try manually setting the cropping to 0 (zero) on all sides to help rule out the previous issues. Thanks. |
Also an interesting line from the x264 encode:
High 4:4:4 Pred 4:2:0... right. |
Hi @bradleysepos, Unfortunately, setting cropping to 0 (all) didn't change a thing. |
What a weird color profile: 5-5-5 . Maybe VCE rejects it and writes something else. Check the color profile of the resulting file in mediainfo. |
5-5-5 is PRI_BT470BG, TRC_GAMMA28, SPC_BT470BG
But still possible that AMF has a problem with certain color spaces. |
|
Yup, before 3712b29 we used to support less color values, and HB_TRA_GAMMA28 was sanitised and replaced by HB_COLR_TRA_BT709 probably. I know VideoToolbox will fail with some color profile combination, and maybe some players will too. I'll do some testing next week. |
FFmpeg AMD VCE encoder does not write the color tag into the H.264 VUI, so the player will have to guess (and probably guess it wrong). HandBrake 1.4 will write the color tag at the container level too, so it should fix this issue at least for those players that reads the container color values. |
AMF doesn't support setting the the color info in the VUI yet. |
Problem description:
If I encode a video with
H.264 (x264)
the output is the same color as the original DVD (opened from folder, not disk).If I encode a video with
H.264 (AMD VCE)
, the output is noticeably brighter.Maybe related/similar to #493, #2788 or #2859?
I would prefer to use
AMD VCE
because it is multiple times faster than pure CPU encoding, but messing up colors is a bummer.(To be fair: the AMD VCE shows more details in dark scences, so maybe AMD VCE's assumtion is actually more original than the other...)
Note:
No filters enabled (so not really #2859).
Also repoduceable on
HandBrake-20200616-cbce13ddf_x86_64-Win_GUI
HandBrake version:
1.3.3
Operating system and version:
Windows 10 2004 (Build 19041.329)
Error message text and/or screenshot:
HandBrake Activity Log:
H.264 (x264) - GOOD:
H.264 (AMD x264) - BAD:
The text was updated successfully, but these errors were encountered: