Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Set resolution limit by long/short side of frame rather than with a bounding box (for handling mixed-orientation sources) #3894

Open
jbruchon opened this issue Oct 5, 2021 · 1 comment

Comments

@jbruchon
Copy link

jbruchon commented Oct 5, 2021

Description of the feature or enhancement you'd like to see in HandBrake

The current implementation of the resolution limit appears to work using a "bounding box" technique, e.g. a 1080x1920 vertical source video with a 1280x720 limit has the vertical (1920) side limited to 720 pixels and the use of "optimal size" will scale the horizontal to maintain aspect ratio.

What I propose is to allow setting the side used for making the limit decision instead, based on relative sizes rather than physical location. For example, a vertical video that's 1080x1920 that is to be scaled down to 720p should be scaled to 720x1280, not 405x720 as the current limiter plus "optimal size" works. If we could instead select "limit the short side to 720" then vertical videos will be scaled as expected.

I'd also like to note (and maybe this needs to be split into a separate issue) that the current "Dimensions" tab is a bit confusing. "Optimal size" seems to really mean "maintain aspect ratio," but there's a "Display Size" thrown in there as well. There is no tooltip when hovering to explain "Optimal Size" or "Scaled Size" or "Display Size." The "Automatic" checkbox tooltip is also incorrect (it says "Keep Aspect Ratio maintains..." when that's not what it's called now.)

What Operating System are you running?

Windows 10

What version of HandBrake are you running?

1.4.1

Where did you download HandBrake from?

handbrake.fr

Activity Log, Crash Log or any other details

No response

@SoiledBrush
Copy link

Yes pls, i need that feature to batch transcode folders with videos that has different orientations.

@jbruchon jbruchon changed the title [Feature Request] Set resolution limit by long/short side of frame rather than with a bounding box [Feature Request] Set resolution limit by long/short side of frame rather than with a bounding box (for handling mixed-orientation sources) Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants