Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DVD LPCM Audio support for Passthru #644

Closed
HackintoshHD opened this issue Mar 18, 2017 · 4 comments
Closed

Add DVD LPCM Audio support for Passthru #644

HackintoshHD opened this issue Mar 18, 2017 · 4 comments

Comments

@HackintoshHD
Copy link

Please describe the problem or feature request in detail: As of HandBrake 1.0.3, passing through regular DVD two-channel LPCM audio by the "Auto Passthru" Codec selection in HandBrake's audio tab is flawed: The audio will indeed be passed through, but gets flagged as AC3 audio in the resulting MPEG4 or Matroska container.

What are the steps to reproduce this problem: Get a DVD containing a two-channel LPCM audio track (e.g. Glenn Gould's Goldberg variations) and transcode it with this audio track chosen in HandBrake's Audio tab using the Codec selection "Auto Passthru".

What version of HandBrake you are running: 1.0.3

What operating system and version and you running (e.g. OSX 10.11, Windows 7, Ubuntu 14): Reproducible under Windows 7 Ultimate SP1 x64, macOS 10.12.3 Sierra, Ubuntu 16.04.02 LTS.

Was there any error message or error dialog, if so please detail or provide screenshots: Checking codec information of the resulting MPEG/MKV container with VLC media player clearly shows the audio track as "A52 Audio (aka AC3) (ac-3)".

@jstebbins
Copy link
Contributor

Please provide an activity log.

HandBrake has never supported passthru of lpcm.

@sr55
Copy link
Contributor

sr55 commented Mar 25, 2017

Actually, I think this might be a request for adding lpcm passthru. He's prbably getting the fallback encoder but obviously we can't know without a log.

If i recall correctly, MP4 doesn't support LPCM audio so that would leave it to MKV only.

Marking as an enhancement for now

@bradleysepos
Copy link
Contributor

Closing as duplicate of #483.

@HackintoshHD
Copy link
Author

First of all, I'm sorry for missing the 'activity log requirement', please apologize I did not provide an activity log earlier.

After getting back into the issue, I now realize I had erroneously assumed lossless audio could be muxed into an MPEG4 container and I somehow had also missed HandBrake's fallback encoder mechanism, which obviously did its job here. - In short, @sr55 's deductions are all accurate:

Actually, I think this might be a request for adding lpcm passthru. He's prbably getting the fallback encoder but obviously we can't know without a log.

If i recall correctly, MP4 doesn't support LPCM audio so that would leave it to MKV only. […]

It however would be highly appreciated, if you could treat my issue report as a feature request for LPCM passthru to MKV containers as part of #483. - Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants