Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue / Bug Roll Up #137

Closed
ColinRobbins opened this issue Feb 9, 2022 · 7 comments
Closed

Issue / Bug Roll Up #137

ColinRobbins opened this issue Feb 9, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@ColinRobbins
Copy link
Contributor

There have been a number of issue reports and PRs recently, but @HandyHat is not currently active.

We have no idea of @HandyHat personal circumstances, and fundamentaly hope they are OK, and will be able to accept a PR soon.

This issue, and associated PR is a roll up of issues, so when @HandyHat come online it will be easy for them to trace what needs doing.

Issues resolved

PR Roll up

This PR contains a roll up of the following PRs, that could be closed if the PR accepted.

Using the PR prior to @HandyHat merging.

The simplest method would be to copy this version of sensor.py (Make sure you use this version, from the dev branch, and not from the main branch) to custom_components/hildebrandglow_dcc and restart HA.
Previous attempts to get HACS to use a forked branch caused lots of issues, and lots of tidying up when @HandyHat was able to accept the PR.
We can look at this in time, if @HandyHat does not come back online in the near future.

Note: When you restart, it can take upto 5 minute for data to pull through. Please give it time before raising issues saying you have no data.

Tariff Data: If you are no seeing Tariff data - check the Glow APP. If there in not data in Glow, do not report an error here - this is nothing this Integration can do - you need to report the issue to your energy provider.

Issues that cloud probably be closed...

Issue to keep open

  • Add multiple accounts #99 - this needs some work in the initialision code. Not clear how many people needed this. Keep open as a feature request.
@ColinRobbins ColinRobbins added the bug Something isn't working label Feb 9, 2022
@HandyHat
Copy link
Owner

HandyHat commented Feb 9, 2022

Apologies, been a bit busy so haven't been able to do a lot of development. I've been trying to catch up over the last day or so after the glow issues, so this is really helpful! I'll be merging some PRs later today

@Davecl
Copy link

Davecl commented Feb 15, 2022

not very used to github but ive been trying to follow the problems/solutions with this integration, after all the outages etc.
Should I wait for an actual update of the integration in HACS or if not what can i do in the meantime?
should i use the sensor.py in this post?
are there other files i can update?

thanks

@ColinRobbins
Copy link
Contributor Author

The current version in HACS should work.
The updates are to provide better error handling if (when) the Glow API breaks again.
Unless you needed the fixes for some reason, I suggest using the current version.

Hopefully @HandyHat will conclude their testing and make a new release soon.

@Davecl
Copy link

Davecl commented Feb 15, 2022

Thanks, I'll continue with the HACS version then

@ColinRobbins
Copy link
Contributor Author

@HandyHat have you been able to consider this PR?
Rolling it out will reduce the load on the Glow API, hopefully making the API more reliable for all of us.

@RCGrahamWilmott
Copy link

Has a version (v0.6.0?) with these fixes been released? I'm still on v0.5.2 and not sure why it is not updating...

@ColinRobbins
Copy link
Contributor Author

No. @HandyHat are you able to make a release so everyone gets updates via HACS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants