Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove\null PerformContext when passed into Schedule #1382

Open
KLuuKer opened this issue Mar 29, 2019 · 0 comments
Open

Remove\null PerformContext when passed into Schedule #1382

KLuuKer opened this issue Mar 29, 2019 · 0 comments

Comments

@KLuuKer
Copy link

KLuuKer commented Mar 29, 2019

some people (i fixed my code already) include a PerformContext into the arguments when scheduling jobs (for example from inside a job)

Example:
BackgroundJob.Enqueue(() => new MyJobClass().SomeMethod(performContext, foo, bar));

Expected: a null as argument stored in the database

Actually: the full perfomContext is serialized in whole and stored in the database

when some job is queueing\scheduling other jobs, and maybe a couple of layers deep you end up with a whole bunch of nested PerfomContext's nested inside each other
so it would be nice to prevent this, and some users may do this without knowing this is very bad

Versions:
Hangfire.Core 1.6.22
Hangfire.SqlServer 1.6.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants