Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented full-width support #1873

Closed
wants to merge 10 commits into from

Conversation

danillewin
Copy link
Contributor

@danillewin danillewin commented Jun 7, 2021

Before:

Fixed width, even when screen width is wider than 1200px

full-screen-before

After:

For screens of all sizes container width is now relative.

Wider than 1200px

full-width-L

992px - 1200px

full-width-M

768 - 992px

full-width-S

Narrower than 768px

full-width-XS

@odinserj
Copy link
Member

Thanks @danillewin 👍, will decide whether it should be available in 1.8.0 or in 1.7.24 and merge it.

@odinserj odinserj added this to the Hangfire 1.8.0 milestone Jun 15, 2021
@odinserj
Copy link
Member

Really awesome, can't wait to merge it. Is it ready to be merged?

src/Hangfire.Core/Dashboard/Content/css/hangfire.css Outdated Show resolved Hide resolved
src/Hangfire.Core/Dashboard/Content/css/hangfire.css Outdated Show resolved Hide resolved
src/Hangfire.Core/Dashboard/Content/css/hangfire.css Outdated Show resolved Hide resolved
src/Hangfire.Core/Dashboard/Content/css/hangfire.css Outdated Show resolved Hide resolved
src/Hangfire.Core/Dashboard/Pages/LayoutPage.cshtml Outdated Show resolved Hide resolved
@odinserj odinserj changed the base branch from master to dev June 30, 2021 10:01
@odinserj
Copy link
Member

odinserj commented Jul 2, 2021

Thanks for making all the changes requested. I've also changed the base branch to dev to land the changes to the 1.8.0 release only (and not to 1.7.X), and merge conflicts appeared (please see the message above). Could you please try to fix those conflicts by merging the dev branch into the PR's one?

@danillewin
Copy link
Contributor Author

Could you please try to fix those conflicts by merging the dev branch into the PR's one?

Sure! Started

@danillewin
Copy link
Contributor Author

Moved here:

#1893

@danillewin danillewin closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants