Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Dispose method instead of Stop for graceful shutdown #244

Closed
odinserj opened this issue Nov 12, 2014 · 1 comment
Closed

Call Dispose method instead of Stop for graceful shutdown #244

odinserj opened this issue Nov 12, 2014 · 1 comment

Comments

@odinserj
Copy link
Member

Thanks to Sam Piper for articulating the problem in this topic. He states that BackgroundJobServer.Stop method is non-blocking, and he wants to have the blocking one to be able to wait for the stop before shutting down the application.

The Stop method is non-blocking, and the Dispose is blocking. And the following pages of the documentation give us a wrong vision:

The OWIN shutdown method is also incorrect a bit, it calls the Stop method instead of Dispose.

@odinserj odinserj added this to the 1.2.0 milestone Nov 12, 2014
@odinserj
Copy link
Member Author

I updated the documentation, left to fix the problem with OWIN shutdown method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant