Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BackgroundJobServer.MachineName validation #60

Closed
odinserj opened this issue Apr 7, 2014 · 1 comment
Closed

Fix BackgroundJobServer.MachineName validation #60

odinserj opened this issue Apr 7, 2014 · 1 comment
Labels
t: bug

Comments

@odinserj
Copy link
Member

odinserj commented Apr 7, 2014

It fully supports RFC 1123 names, but validation rules does not satisfy NetBIOS name limitations.
This is very serious issue, because it can lead to inability to use the library on some hosts.
@odinserj odinserj added the bug label Apr 7, 2014
@odinserj
Copy link
Member Author

odinserj commented Apr 7, 2014

Decided to remove MachineName validation. I created it to limit the server naming creativeness. But by default it is equal to current server hostname, and I can't put such restrictions.

@odinserj odinserj assigned odinserj and unassigned odinserj May 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: bug
Milestone
No milestone
Development

No branches or pull requests
1 participant
@odinserj