Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guarantee slash in rename #2756

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Conversation

jojo2357
Copy link
Contributor

Minimal fix to #2752

Summary of additions and changes

  • Help prevent the user from renaming the command to an illegal or incomplete command name

How to test this pull request

\newcommand{\mycommand}{my command}

The old format would have accepted `a` and `\` since it didnt check if the input string was of sufficient length. By using regex we will deny just `\` but permit `a` intentionally.
@PHPirates PHPirates added this to the b0.7.25 milestone Nov 10, 2022
@jojo2357 jojo2357 marked this pull request as ready for review November 10, 2022 19:57
@jojo2357
Copy link
Contributor Author

Well I am going to look into making a custom rename dialog, but that can be in a separate pr tbh since it won't be this easy and I think there are bigger fish to fry like #2722

@PHPirates PHPirates merged commit aab0b5b into Hannah-Sten:master Nov 10, 2022
@jojo2357 jojo2357 deleted the renameimprovements branch November 10, 2022 20:00
@PHPirates
Copy link
Collaborator

What would be the advantage of having a custom rename dialog? Just UI?

@jojo2357
Copy link
Contributor Author

well the big idea would be that it would give the user commandName instead of \commandName since it would have its own createDialog implementation that would set the label text correctly. Not much else in the way of functionality since this fix was added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants