Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone #2 To-Do List: Add-Remove-Edit #2

Merged
merged 5 commits into from Jul 9, 2022
Merged

Conversation

Hannziegel
Copy link
Owner

To-Do List: Add-Remove-Edit

  • Remove all hardcoded items from the tasks array.
  • Created javascript file for the Classes
  • Implement a function for adding a new task (add a new element to the array)
  •       new tasks have the properties: completed = false, index = to the value of the new array length
    
  • Implement a function for deleting a task (remove an element from the array).
  •      that updates all remaining items' indexes, so they represent the current list order and are unique
    
  • Implement a function for editing task descriptions.
  • All changes to the To-Do List are saved in local storage.

Live Version

@github-pages github-pages bot temporarily deployed to github-pages July 9, 2022 00:18 Inactive
Copy link

@AshakaE AshakaE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hannziegel ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Hannziegel Hannziegel merged commit 4826eeb into main Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants