Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pwa): Fix offline functionality #350

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Conversation

Hanziness
Copy link
Owner

@Hanziness Hanziness commented May 31, 2023

Previously the Workbox module cached most of the app's assets for offline use, but not the main page, resulting in a "No internet" page when loading the app offline. This PR should fix that, and it also adjusts the workings of the service worker and icon generator to output into the public folder instead of the build directory (since Nuxt 3.5.x files in the build folder aren't copied into the final dist folder anymore).

@Hanziness Hanziness linked an issue May 31, 2023 that may be closed by this pull request
@Hanziness Hanziness merged commit 4ef1bb0 into develop Jun 5, 2023
1 check passed
@Hanziness Hanziness deleted the 347-offline-viewing branch June 5, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offline viewing
1 participant