Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Handle ~ or be more explicit #24

Closed
HaoZeke opened this issue Oct 22, 2023 · 0 comments · Fixed by #55
Closed

ENH: Handle ~ or be more explicit #24

HaoZeke opened this issue Oct 22, 2023 · 0 comments · Fixed by #55
Assignees
Labels
enhancement New feature or request ropensci-review Issues related to the ROpenSci review
Milestone

Comments

@HaoZeke
Copy link
Member

HaoZeke commented Oct 22, 2023

it seems the lib cannot handle paths with ~ (?) If this cannot be made to work easily, some error message would be very helpful, I think it would be needed
to be added here: https://github.com/HaoZeke/fastMatMR/blob/main/src/to_file.cpp#L26 The corresponding read file returns an error message: 'cannot open file' which is more helpful.
(I am guessing the issue is related to ~ in path because write_fmm(vec, "~/vector.mtx") returned false for me while write_fmm(vec, "/home/ildi_home/vector.mtx") worked)

First noted here: ropensci/software-review#606 (comment).

Generally, since R needs to work on Windows as well, supporting ~ will be hard, but a better error message would be nicer.

@HaoZeke HaoZeke added the ropensci-review Issues related to the ROpenSci review label Oct 22, 2023
@HaoZeke HaoZeke added this to the v1.0.0 milestone Oct 22, 2023
@HaoZeke HaoZeke self-assigned this Oct 22, 2023
@HaoZeke HaoZeke added the enhancement New feature or request label Oct 22, 2023
HaoZeke added a commit that referenced this issue Oct 22, 2023
HaoZeke added a commit that referenced this issue Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ropensci-review Issues related to the ROpenSci review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant