Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Do not write to project root #44

Closed
HaoZeke opened this issue Oct 22, 2023 · 0 comments · Fixed by #54
Closed

TST: Do not write to project root #44

HaoZeke opened this issue Oct 22, 2023 · 0 comments · Fixed by #54
Labels
maintenance ropensci-review Issues related to the ROpenSci review test Associated with the test suite
Milestone
v1.0.0

Comments

@HaoZeke
Copy link
Member

HaoZeke commented Oct 22, 2023

Ideally, tests would not write to the project root in my opinion even if those files are added
to .gitignore, but rather write to a temp directory. https://testthat.r-lib.org/articles/test-fixtures.html might help find a more robust solution.

First noted here: ropensci/software-review#606 (comment).
@HaoZeke HaoZeke added maintenance test Associated with the test suite labels Oct 22, 2023
@HaoZeke HaoZeke added this to the v1.0.0 milestone Oct 22, 2023
@HaoZeke HaoZeke added the ropensci-review Issues related to the ROpenSci review label Oct 22, 2023
@HaoZeke HaoZeke changed the title TST: Do not write to project room TST: Do not write to project root Oct 22, 2023
HaoZeke added a commit that referenced this issue Oct 22, 2023
@HaoZeke
TST: Add tempdir fixtures and refactor tests
e9cc389 
Closes #44. Closes #45.
@HaoZeke HaoZeke mentioned this issue Oct 22, 2023
Merged
@HaoZeke HaoZeke mentioned this issue Oct 24, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance ropensci-review Issues related to the ROpenSci review test Associated with the test suite
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

TST: Add tempdir fixtures and refactor tests ropensci/fastMatMR
1 participant
@HaoZeke