New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Better error handling #49

Closed

HaoZeke opened this issue Oct 22, 2023 · 1 comment

Labels

maintenance ropensci-review

Milestone

Member

HaoZeke commented Oct 22, 2023

what happens if cpp lib call fails for some reason? Will the file handle be closed properly? See https://github.com/HaoZeke/fastMatMR/blob/main/src/to_file.cpp#L30

First noted here: ropensci/software-review#606 (comment).

I'm not sure this can even happen though..

HaoZeke added ropensci-review maintenance labels

HaoZeke added this to the v1.0.0 milestone

Member Author

HaoZeke commented Oct 23, 2023

If os.open() fails the function will return FALSE, and nothing else needs to be done.

HaoZeke closed this as completed

HaoZeke mentioned this issue

fastMatMR: Fast Matrix Market I/O ropensci/software-review#606

Closed

29 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment