You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a lot of duplicate code accumulating in node.py. Can we find a simpler, more compact way to define node operations that can be translated to the different compilation options (numpy, sympy etc) behind the scenes? It would be great if the definition of, for example, the addition and parameter nodes would reduce to this:
I think it would be really nice to organize the Node classes into a hierarchical structure. I am not sure how to realize a scenario from your code snippet, though. How would these strings be parsed?
There is a lot of duplicate code accumulating in
node.py
. Can we find a simpler, more compact way to define node operations that can be translated to the different compilation options (numpy, sympy etc) behind the scenes? It would be great if the definition of, for example, the addition and parameter nodes would reduce to this:It's possible that we'll need to introduce new subclasses of
Node
such asUnaryNode
,BinaryNode
etc to implement this cleanly.This would also allow us to easily add new compilation options without touching the definition of every single
Node
subclass.The text was updated successfully, but these errors were encountered: