Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set reorder=True per default. #360

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Set reorder=True per default. #360

wants to merge 3 commits into from

Conversation

HenrikMettler
Copy link
Contributor

Moves the boolean reorder_genome into population to check whether genome conditions (n_rows=1, levels_back=n_columns) for reorder=True are met.
I am not removing the possibility to configure this, since reorder is limited to certain genome parameter configurations.
Closes #347.

@jakobj jakobj added this to the 0.4.0 milestone Jan 17, 2022
@jakobj
Copy link
Member

jakobj commented Jan 17, 2022 •
edited

good catch that we can not just remove the configuration option for reorder while we support multiple rows.

how do you feel about removing the possibility of setting n_rows and always use n_rows=1? my impression is that modern general purpose CGP anyways uses exclusively only one row but may columns, while multiple rows were historically used for evolving circuits.

@HenrikMettler
Copy link
Contributor Author

yeah, i think I agree. Should we also remove levels_back? Atm I can't see any use case where anything but levels_back=n_columns is useful.

@jakobj
Copy link
Member

jakobj commented Jan 19, 2022

yes, i think you're right, levels_back can also be removed. 👍

could you please create a separate PR, removing n_rows and levels_back? after that has been merged, we can come back to this one.

@HenrikMettler HenrikMettler marked this pull request as draft January 20, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobj jakobj Awaiting requested review from jakobj

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Always use reorder=True and remove possiblity to configure this?
2 participants
@HenrikMettler @jakobj