Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename module "python-gp" -> "hal-cgp" #115

Merged
merged 1 commit into from
May 25, 2020
Merged

Rename module "python-gp" -> "hal-cgp" #115

merged 1 commit into from
May 25, 2020

Conversation

jakobj
Copy link
Member

@jakobj jakobj commented May 13, 2020 •
edited
Loading

as discussed.

as soon as this is approved, before merging, i will rename the repository to make sure everything is in a consistent state.

@jakobj jakobj added the API change The label that should be avoided label May 13, 2020
@jakobj jakobj added this to the 0.1.0 milestone May 13, 2020
@jakobj jakobj requested a review from mschmidt87 May 13, 2020 17:16
@coveralls
Copy link
Collaborator

coveralls commented May 13, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.637% when pulling c488a4e on jakobj:maint/rename-module into 5e6b057 on Happy-Algorithms-League:master.

mschmidt87
mschmidt87 approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@mschmidt87 mschmidt87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mschmidt87
Copy link
Member

Please resolve the conflicts so that we can merge this asap. @jakobj

@jakobj jakobj force-pushed the maint/rename-module branch 2 times, most recently from 2304d54 to 76ac8fc Compare May 25, 2020 11:19
@jakobj
Copy link
Member Author

jakobj commented May 25, 2020

ok, rebased on current master. let's see what travis thinks.

@jakobj
Copy link
Member Author

jakobj commented May 25, 2020

all checks passed. merging.

@jakobj jakobj merged commit 8bb73db into Happy-Algorithms-League:master May 25, 2020
@jakobj jakobj deleted the maint/rename-module branch May 25, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschmidt87 mschmidt87 mschmidt87 approved these changes

Assignees
No one assigned
Labels
API change The label that should be avoided
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakobj @coveralls @mschmidt87