Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify travis config file to add job matrix #120

Merged
merged 3 commits into from
May 27, 2020
Merged

Conversation

mschmidt87
Copy link
Member

@mschmidt87 mschmidt87 commented May 25, 2020

This PR adds jobs to the CI that test the libraries without extra requirements. Closes #103 and fixes the detected issues:

  • put annotations using optional dependencies in quotation marks
  • mark torch- and sympy-dependent tests as skip

It furthermore fixes some minor issues with flake8 and makes coveralls actually look at the library, not at the tests.

Exclude Py 3.6 and 3.7 without additional requirements from job matrix
Copy link
Member

@jakobj jakobj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, already looks good ✨ only three small comments that should be addressed before merging.

can't believe we constantly checked the coverage of the testsuite. kind of upsetting it's not 100% ;)

.travis.yml Outdated Show resolved Hide resolved
test/test_individual.py Outdated Show resolved Hide resolved
test/test_individual.py Outdated Show resolved Hide resolved
Stringify annotations using optional dependencies
Mark test relying on optional dependencies as skip
Demote f-string to normal string
Fix flake8 issue in setup.py
Copy link
Member

@jakobj jakobj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome stuff 👍 and merging

@jakobj jakobj merged commit c9acc7b into master May 27, 2020
@jakobj jakobj deleted the maint/CI_add_jobs branch May 27, 2020 10:34
@mschmidt87 mschmidt87 added this to the 0.1.0 milestone Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configurations without torch and sympy to Travis CI
2 participants