Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to choose Firefox Klar for link handling #760

Closed
rm-rf-home opened this issue Feb 10, 2019 · 14 comments
Closed

Not able to choose Firefox Klar for link handling #760

rm-rf-home opened this issue Feb 10, 2019 · 14 comments

Comments

@rm-rf-home
Copy link

First of all thanks for the great app.

The problem

I'm not able to choose the browser "Firefox Klar" in the link handling settings. Maybe it has something to do with the fact that "Firefox Focus" support is already in place but in German speaking countries the app is available under a different name "Firefox Klar": https://support.mozilla.org/en-US/kb/difference-between-firefox-focus-and-firefox-klar

Environment

  • Slide version that exhibits the issue: 2.1.2 build 84 (from German App Store)
  • iOS version used to run Slide: 12.1.4 (16D57)
  • iOS device type: iPhone 7
  • Installed Browser: Firefox Klar 8.0 (from German App Store)

img_2013
img_2015

@ccrama
Copy link
Collaborator

ccrama commented Feb 10, 2019

I cannot find the app on the App Store to be able to find it's internal link tag. For example, firefox focus is firefox-focus://URL. If you are able to figure that out I can add support for Klar!

@colejd
Copy link
Collaborator

colejd commented Feb 10, 2019

firefox-klar?

@ccrama
Copy link
Collaborator

ccrama commented Feb 10, 2019

I would need confirmation because we cannot test this in the US @colejd

@colejd
Copy link
Collaborator

colejd commented Feb 10, 2019

https://en.m.wikipedia.org/wiki/Firefox_Focus

It looks to me like a separate branded version just for Germany.

@ccrama
Copy link
Collaborator

ccrama commented Feb 10, 2019

The issue is the url scheme is not the same as the normal firefox app, which Slide does support. And because it's just in germany, we can't test other variants

@rm-rf-home
Copy link
Author

It's probably "firefox-klar://". I found this after a lot of googling: mozilla-lockwise/lockwise-ios@54e95b1

@colejd
Copy link
Collaborator

colejd commented Feb 10, 2019

;)

@rm-rf-home
Copy link
Author

Is there a way for me to test it? I would love to help.

@colejd
Copy link
Collaborator

colejd commented Feb 10, 2019

Try firefox-klar://open-url?url=https://www.google.com

@rm-rf-home
Copy link
Author

Looks good, it opens google in Klar on my iPhone

@ccrama
Copy link
Collaborator

ccrama commented Feb 11, 2019

Added support in the next beta build! I cannot test this, so if it works please close the issue

@rm-rf-home
Copy link
Author

Will do!

@ccrama
Copy link
Collaborator

ccrama commented Feb 11, 2019

Should be out now @rm-rf-home :)

@rm-rf-home
Copy link
Author

Works great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants