Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1336] Fix issues with gFasterHeavyBlockLift #1476

Merged
merged 1 commit into from
Sep 20, 2022
Merged

[#1336] Fix issues with gFasterHeavyBlockLift #1476

merged 1 commit into from
Sep 20, 2022

Conversation

garrettjoecox
Copy link
Contributor

@garrettjoecox garrettjoecox commented Sep 15, 2022 •
edited

  • Fixes issue with silver blocks not being sped up
  • Fixes issue causing softlocks if you enable then disabled the enhancement
  • Fixes issue that would leave obelisks in the wrong position after being thrown (this was especially a problem for the fire trial)
  • Enhancement now prevents the OnePointCutscene from being played for obelisks
  • Reverts parts of Speed up lifting silver rocks and obelisks by 5x #953

Resolves #1336

@dcvz
Copy link
Contributor

dcvz commented Sep 15, 2022

@aMannus would you have a chance to verify this fix? I see you wrote the original issue :)

aMannus
aMannus approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@aMannus aMannus left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM 👍

briaguya-ai
briaguya-ai approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Kenix3 Kenix3 merged commit 34d6212 into HarbourMasters:develop-zhora Sep 20, 2022
Kenix3 pushed a commit to Kenix3/Shipwright that referenced this pull request Oct 19, 2022
@garrettjoecox @Kenix3
[HarbourMasters#1336] Fix issues with gFasterHeavyBlockLift (HarbourM…
6f97d2b 
…asters#1476)
@garrettjoecox garrettjoecox deleted the 1336-fix-gFasterHeavyBlockLift branch October 19, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcvz dcvz dcvz approved these changes

@aMannus aMannus aMannus approved these changes

@Kenix3 Kenix3 Kenix3 approved these changes

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
merge ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Faster Heavy Block Lift" enhancement bugs
5 participants
@garrettjoecox @dcvz @aMannus @Kenix3 @briaguya-ai