Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rumble and check tracker fixes #2419

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Rumble and check tracker fixes #2419

merged 2 commits into from
Jan 30, 2023

Conversation

Sirius902
Copy link
Contributor

@Sirius902 Sirius902 commented Jan 29, 2023 •
edited by github-actions bot

Just some fixes for things I encountered when I did a rando the other day.

Fixes

  • It seems my rumble changes in f217b9b were unintentionally undone by f712068, meaning that rumble is x3 too long again. I'm assuming this was done to only process inputs once per frame, but the rumble loop was not moved to the correct place. This fixes that so rumble length should be normal again.
  • The rando check tracker will not clean itself up if you reload the game with the check tracker window closed which means loading the game with the check tracker open, then closing it, and loading the game again will result in check locations being duplicated. Eventually this will crash the game. To fix this I changed the check tracker to clean itself up before initializing which seems to work fine.

Build Artifacts

@briaguya-ai briaguya-ai merged commit 44f963e into HarbourMasters:develop Jan 30, 2023
@Sirius902 Sirius902 deleted the fixes branch January 30, 2023 22:40
@Archez Archez mentioned this pull request Feb 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sirius902 @briaguya-ai