Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement built in Extractor for Windows #2730

Merged
merged 40 commits into from
Apr 25, 2023

Conversation

louist103
Copy link
Contributor

@louist103 louist103 commented Apr 21, 2023

@briaguya-ai
Copy link
Contributor

tested and can confirm the behavior on linux has not changed at all and it still works

@GreatArgorath
Copy link
Member

Tested and can confirm it works perfectly on Mac too

@briaguya-ai
Copy link
Contributor

tested and working on switch

Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good! Mostly cleanup comments

OTRExporter/OTRExporter/Main.cpp Outdated Show resolved Hide resolved
ZAPDTR/ZAPD/CMakeLists.txt Outdated Show resolved Hide resolved
ZAPDTR/ZAPD/ExecutableMain.cpp Outdated Show resolved Hide resolved
ZAPDTR/ZAPD/GameConfig.cpp Outdated Show resolved Hide resolved
ZAPDTR/ZAPD/Globals.cpp Outdated Show resolved Hide resolved
soh/CMakeLists.txt Outdated Show resolved Hide resolved
soh/soh/Extractor/Extract.cpp Outdated Show resolved Hide resolved
soh/soh/Extractor/Extract.cpp Outdated Show resolved Hide resolved
soh/soh/Extractor/Extract.cpp Outdated Show resolved Hide resolved
soh/soh/Extractor/Extract.cpp Outdated Show resolved Hide resolved
louist103 and others added 12 commits April 24, 2023 22:57
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
@briaguya-ai briaguya-ai merged commit aea46e7 into HarbourMasters:develop Apr 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants