Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update Player/Actor Flags #2765

Merged
merged 6 commits into from
May 30, 2023
Merged

Docs: Update Player/Actor Flags #2765

merged 6 commits into from
May 30, 2023

Conversation

stratomaster64
Copy link
Contributor

@stratomaster64 stratomaster64 commented Apr 28, 2023 •
edited by github-actions bot

Credit goes to the ZRET members who originally found this information, as well as @Archez. I'm just simply putting it here.

Build Artifacts

garrettjoecox
garrettjoecox approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Champion

soh/include/z64actor.h Outdated Show resolved Hide resolved
@stratomaster64
Copy link
Contributor Author

stratomaster64 commented Apr 28, 2023 •
edited

  • Update Flag Editor to show state# values as opposed to numbers

@stratomaster64 stratomaster64 marked this pull request as ready for review April 29, 2023 02:22
briaguya-ai
briaguya-ai approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a clean find/replace for most of the changes, and everything else looks good!

:shipit:

leggettc18
leggettc18 approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@leggettc18 leggettc18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legendary

@leggettc18 leggettc18 merged commit 71662c5 into HarbourMasters:develop May 30, 2023
7 checks passed
@stratomaster64 stratomaster64 deleted the flag-docs branch June 6, 2023 01:32
@garrettjoecox garrettjoecox added this to the Sulu (7.1.x) milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjoecox garrettjoecox garrettjoecox approved these changes

@leggettc18 leggettc18 leggettc18 approved these changes

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
merge ready
Projects
None yet
Milestone
Sulu (7.1.x)
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stratomaster64 @garrettjoecox @leggettc18 @briaguya-ai